Fix: .signTransaction from dapp browser web3 call should only sign not sign+send

[hboon]

Fixes #6351

[oa-s]

uniswap looks broken with this pr

[oa-s]

@hboon It looks like not all changes that is needed, guess there is mistake in js file aplied to WebView.
we handle processTransaction from js file, and treat it as signTransaction that we receive in web browser, out of js file
HookedWalletSubprovider.prototype.processTransaction uses for sending transaction.
there is also processSignTransaction, that should be used for signing transaction, and looks like we skipping it
HookedWalletSubprovider.prototype.processSignTransaction

[oa-s]

we might need to add webViewConfig.userContentController.add(messageHandler, name: Method.sendTransaction.rawValue) as there is no such line in addition there might be need to replace processTransaction to make it send sendTransaction insteead of signTransaction:

                   processTransaction: function (tx, cb){
                       console.log('sending a transaction', tx)
                       const { id = 8888 } = tx
                       AlphaWallet.addCallback(id, cb)
                       webkit.messageHandlers.sendTransaction.postMessage({"name": "sendTransaction", "object":     tx, id: id})
                   },

[oa-s]

and also need to define processSignTransaction for AlphaWallet js provider, looks like it not visible, the is required js file changes

[oa-s]

@hboon do we have example dapp for testing, looks like uniswap don't work with goerli anymore, (at list for me)

[hboon]

Not that I know of now. I can dig into this issue/PR if you like. Might build a test dapp.

[hboon]

When testing against Uniswap, I use Polygon — cheaper :P

[hboon]

Can you help reject the PR first? Just in case. Clearer :)

rejection

[oa-s]

Can you help reject the PR first? Just in case. Clearer :)

am i did right?

[hboon]

Seems ok. GitHub seems a little strange. Not what I expected. But looks alright. Thanks.

[hboon]

Apparently we don't support eth_signTransaction (which is sign, but not send) in the dapp browser. We only support eth_sendTransaction (which is sign+send). Created AlphaWallet/AlphaWallet-web3-provider#36. Will delay it unless it's necessary for Uniswap.

(maybe you were referring to tat missing support earlier up there)

Can you help to verify that it Uniswap works with master (if it does, can you list the steps to reproduce?). If it does and this PR breaks it, then we'll fix it, otherwise, I'll clean this PR up and try to merge it again

[hboon]

Oh I checked the PR, and looks like if we rebase master, it already includes the changes in this PR, i.e. .signThenSend -> .sign for .signTransaction since the handling for signing and sending transaction are now centralized with the recent refactor.

So we can close this PR once we figure out if Uniswap is broken for us.

[oa-s]

@hboon looks like this can be closed, isn't it?

[hboon]

Yes. Seems so. I’ll take a look to be sure.