Use Cray compiler wrappers in manual Polaris builds #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrush
approved these changes
Jun 13, 2023
|
Looks good, let me know if there any more changes needed, if not I will merge. |
|
Cool! In that case, it doesn't need any more changes. Thanks! |
|
great -- merged -- thanks for confirming, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves upon #1148, the Cray compiler wrappers are now used to build on Polaris instead of using gcc, g++, and gfortran directly. It turns out that the ALCF documentation I originally referenced for how to swap from NVHPC to GCC was not correct.
Just one caveat here: compiling RAJA with the updated script runs into this error. The fix is to set
-D RAJA_ENABLE_VECTORIZATION=OFFwhen building RAJA, which defaults toON.There are several ways to get around this, and I wasn't sure what the preferred way would be. I settled on making it an option that leaves the default alone, but lets me disable it for Polaris builds specifically. Would appreciate your thoughts, I'm happy to change it however you think is best.