Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raja binning fixes #1238

Merged
merged 14 commits into from
May 11, 2024
Merged

raja binning fixes #1238

merged 14 commits into from
May 11, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Dec 13, 2023

fix raja binning implementation and switch to use it
add more tests

@cyrush
Copy link
Member Author

cyrush commented Apr 19, 2024

Screenshot 2024-04-19 at 11 46 04 AM

RAJA Binning is not creating the proper input samples, it seems like the centroids are way off.
Above is a count case, elements in each output column should have the same value. The outer columns should match and the inner column should have higher values.

Input is a 6x6x6 cube. Purple shows the bin boundaries. Output bins are a 3x6x1 mesh.

@cyrush
Copy link
Member Author

cyrush commented Apr 19, 2024

Screenshot 2024-04-19 at 12 13 14 PM

@cyrush
Copy link
Member Author

cyrush commented Apr 19, 2024

sample points are bogus

@cyrush
Copy link
Member Author

cyrush commented Apr 19, 2024

Screenshot 2024-04-19 at 12 15 35 PM

trying different ordering, still bogus

@cyrush
Copy link
Member Author

cyrush commented May 11, 2024

there are still issues with the new raja implementation, but this is good forward progress. Old binning implementation is wired up with new tests.

@cyrush cyrush merged commit 0aef6cf into develop May 11, 2024
20 checks passed
@cyrush cyrush deleted the task/2023_12_raja_binning_fixes branch May 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant