Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify kokkos init logic #1286

Merged
merged 2 commits into from
May 9, 2024
Merged

simplify kokkos init logic #1286

merged 2 commits into from
May 9, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented May 9, 2024

resolves #1127

nicolemarsaglia
nicolemarsaglia approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@nicolemarsaglia nicolemarsaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo real nice, I like we can select a device now!

@cyrush cyrush merged commit edf0f4c into develop May 9, 2024
20 checks passed
@cyrush cyrush deleted the task/2024_05_simplify_kokkos_init_logic branch May 9, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolemarsaglia nicolemarsaglia nicolemarsaglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

are we double initing?
2 participants
@cyrush @nicolemarsaglia