Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kokkos with cuda #1303

Closed
wants to merge 4 commits into from
Closed

Conversation

nicolemarsaglia
Copy link
Contributor

No description provided.

Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the test failure is unrelated to your changes.

I opened #1304 to track that failure.

Nicole Jo Ann Marsaglia and others added 2 commits May 22, 2024 13:10
@nicolemarsaglia
Copy link
Contributor Author

Current super-fun-time, no-good error:
lulesh_cuda_break.txt

@cyrush
Copy link
Member

cyrush commented May 22, 2024

Maybe we are missing some sources that need to be tagged as device sources?

set(ascent_device_sources runtimes/expressions/ascent_memory_manager.cpp

I thought we cover all of those cases via our static cuda build, but maybe using kokkos with VTK-m opens up new cases?

@nicolemarsaglia
Copy link
Contributor Author

Maybe we are missing some sources that need to be tagged as device sources?

set(ascent_device_sources runtimes/expressions/ascent_memory_manager.cpp

I thought we cover all of those cases via our static cuda build, but maybe using kokkos with VTK-m opens up new cases?

/usr/tce/packages/gcc/gcc-9.3.1/rh/usr/bin/../libexec/gcc/ppc64le-redhat-linux/9/ld: ../../../lib/libascent.so: undefined reference to '__cudaRegisterLinkedBinary_56_tmpxft_0001a5d5_00000000_7_ascent_memory_manager_cpp1_ii_5b8ab178'

If it was about missing sources then this file wouldn't be failing, right? And the files the errors reference seem like a (deterministic) grab bag.

@nicolemarsaglia nicolemarsaglia deleted the task/2024_05_kokkos_cuda branch August 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants