VTK-m MIR #1326
Merged
VTK-m MIR #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculated vtkm fields in the data adapter rather than filter for my sanity.
…y_element seg faulting in vtkm
…ine into full's calcs
…l need to hunt down zero-copy bug in vtkm. Otherwise done.
cyrush
reviewed
Jul 10, 2024
| int *is_discrete = new int(); | ||
| *is_discrete = 1; | ||
| graph().workspace().registry().add<int>("is_discrete", | ||
| is_discrete, |
There was a problem hiding this comment.
wondering if there is another way to do this hand shake?
There was a problem hiding this comment.
Stripped this out and now it's a param for pseudocolor plots
cyrush
reviewed
Jul 10, 2024
CHANGELOG.md
Outdated
| @@ -38,13 +38,16 @@ and this project aspires to adhere to [Semantic Versioning](https://semver.org/s | |||
| - Added a `vtk` extract that saves each mesh domain to a legacy vtk file grouped, with all domain data grouped by a `.visit` file. | |||
| - Added particle advection for streamline and related rendering support. | |||
| - Added WarpX Streamline filter that uses charged particles. | |||
| - Added Uniform Grid Sampling filter. | |||
| - Added Material Interface Reconstruction (`mir`) filter which produces `cellMat` output field. | |||
There was a problem hiding this comment.
Instead of cell mat, could we use the matset name as the field name?
If there are multiple matsets, one name could lead to a collision.
There was a problem hiding this comment.
Got this changed
…github.com/Alpine-DAV/ascent into task/2024_05_vtkm_material_interface_recon
…a color_table pseudocolor param
…cks to diff in mat_id range
cyrush
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently does not support zero-copy