Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds mpi ranks fields #1349

Merged
merged 11 commits into from
Aug 20, 2024
Merged

adds mpi ranks fields #1349

merged 11 commits into from
Aug 20, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Aug 3, 2024

No description provided.

(cherry picked from commit 0353a74)
(cherry picked from commit dd72250)
@cyrush cyrush mentioned this pull request Aug 3, 2024
Copy link
Member Author

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

(Note: I can't approve b/c I created this branch!)

@nicolemarsaglia
Copy link
Contributor

Looks good!

(Note: I can't approve b/c I created this branch!)

LOL at first I was thinking "shouldn't this be the other way around?"

I was going to add to the docs today

@cyrush
Copy link
Member Author

cyrush commented Aug 19, 2024

@nicolemarsaglia sounds good!

@cyrush cyrush merged commit db26d23 into develop Aug 20, 2024
22 checks passed
@cyrush cyrush deleted the task/2024_08_mpi_rank_and_domain_fields branch August 20, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants