Task/2024 07 camfrust meshes #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_blueprint.py" directly into runtime rendering filters.
1. camera_frustum: line mesh showing the view frustum of the camera. 2. clipping_planes: quad mesh of the camera_frustum that will allow users to determine what, if anything, is not within the camera view. 3. scene_bounds: line mesh that shows the bounding box around the original scene.
cyrush
approved these changes
Aug 9, 2024
| if(n["runtimes/ascent/vtkm/status"].as_string() == "disabled") | ||
| { | ||
| ASCENT_INFO("Ascent support disabled, skipping 3D default" | ||
| "Pipeline test"); |
There was a problem hiding this comment.
let's adjust this message to reflect the name of the test
|
|
||
| EXPECT_TRUE(conduit::blueprint::mesh::verify(data,verify_info)); | ||
|
|
||
| ASCENT_INFO("Testing 3D Rendering with Default Pipeline"); |
There was a problem hiding this comment.
let's adjust this message to reflect the name of the test
|
Note: If you push updates, or merge develop back into your branch and push, the cuda CI test cases should now pass. |
…_07_camfrust_meshes
|
We are green, looks good + thanks again! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.