feat: Add support for dbt_integration_id also#53
Merged
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b08db32 in 33 seconds. Click for details.
- Reviewed
81lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/core/platforms/dbt/cli/cli.py:137
- Draft comment:
The new click.option aliases for integration ID are correctly added. Consider clarifying the help text to avoid ambiguity between 'DBT Core Integration ID' and 'DBT Integration ID'. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/datapilot/core/platforms/dbt/cli/cli.py:155
- Draft comment:
Ensure that renaming to 'dbt_integration_id' and 'dbt_integration_environment' is reflected consistently in downstream function calls (onboard_file and start_dbt_ingestion). - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. src/datapilot/core/platforms/dbt/cli/cli.py:195
- Draft comment:
The URL construction using the new integration parameters appears correct; double-check that the backend expects these new identifiers. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_e7ouObtflda1FA0i
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed d45f4f3 in 46 seconds. Click for details.
- Reviewed
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/datapilot/core/platforms/dbt/cli/cli.py:133
- Draft comment:
Unified integration ID option: ensure the help text clearly indicates support for both '--dbt_core_integration_id' and '--dbt_integration_id'. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/datapilot/core/platforms/dbt/cli/cli.py:151
- Draft comment:
Onboard signature update: confirm that the auth_options decorator now correctly supplies token, instance_name, and backend_url, replacing the unused 'ctx' parameter. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_v7UhYX8OThB5jx1D
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
mdesmet
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add support for
dbt_integration_idinonboardcommand incli.py.--dbt_integration_idand--dbt_integration_environmentoptions inonboardcommand incli.py.onboardfunction to usedbt_integration_idanddbt_integration_environmentinstead ofdbt_core_integration_idanddbt_core_integration_environment.onboardcommand options to reflect new functionality.This description was created by
for d45f4f3. You can customize this summary. It will automatically update as commits are pushed.