refactor: update manifest wrapper to use model_dump and supported lan…

[mdesmet]

…guages

---

Important

Refactor ManifestV12Wrapper to use model_dump() for configuration and language handling in wrapper.py.

• Refactor:
  • Update ManifestV12Wrapper in wrapper.py to use model_dump() for AltimateNodeConfig in _get_node().
  • Use model_dump() for AltimateMacroArgument in _get_macro().
  • Use model_dump() for AltimateSourceConfig in _get_source().
• Enhancements:
  • Process supported_languages in _get_macro() using AltimateSupportedLanguage for better language handling.

^{This description was created by for f9bde24. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to f9bde24 in 1 minute and 18 seconds. Click for details.

• Reviewed 32 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. src/datapilot/core/platforms/dbt/wrappers/manifest/v12/wrapper.py:91

• Draft comment:
  Good use of model_dump() over dict; ensure node.config supports model_dump() for consistency.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. src/datapilot/core/platforms/dbt/wrappers/manifest/v12/wrapper.py:186

• Draft comment:
  Check behavior for supported_languages: returning None on empty list may be unintended; consider returning an empty list.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a style preference rather than a clear bug. Both None and [] are valid ways to represent "no supported languages". Without seeing the schema or how this field is used, we can't definitively say one is better. The current code is consistent with how other optional lists are handled in this file (see arguments, docs handling). The comment is speculative about the intention. The comment could be right - an empty list might be more semantically accurate than None for representing "no supported languages". Empty collections vs None is a common design discussion point. While the suggestion isn't wrong, the current code follows an established pattern in the codebase. Without clear evidence of problems, changing it could reduce consistency. Delete the comment. This is a style preference without clear evidence of being problematic, and the current code follows consistent patterns in the codebase.

3. src/datapilot/core/platforms/dbt/wrappers/manifest/v12/wrapper.py:35

• Draft comment:
  Import of AltimateSupportedLanguage added; confirm this is the intended type for language conversion.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_UEM7H2JRd4JU7f7u

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}