Closed
Conversation
Changed package name from 'altimate-datapilot-cli' to 'altimate_datapilot_cli' in setup.py to comply with PyPI's filename requirements. PyPI requires distribution filenames to use underscores, not hyphens. This fixes the 400 Bad Request error during package upload: 'Filename altimate-datapilot-cli-0.1.1.tar.gz is invalid, should be altimate_datapilot_cli-0.1.1.tar.gz.' Note: Users can still install using either 'pip install altimate-datapilot-cli' or 'pip install altimate_datapilot_cli' as PyPI normalizes package names. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 0985ae6 in 23 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. setup.py:15
- Draft comment:
Correct package name update to use underscores for PyPI compliance. Ensure any related docs or metadata references are updated as needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_JhniN0DhFozDWsDR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
Author
|
Closing this PR to investigate further. Version 0.1.1 appears to already be on PyPI despite the workflow error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
altimate-datapilot-clitoaltimate_datapilot_clito comply with PyPI filename requirementsProblem
The tag-release workflow was failing with a 400 Bad Request error from PyPI:
Solution
PyPI requires distribution filenames to use underscores (
_) instead of hyphens (-). This change updates the package name in setup.py to meet this requirement.Impact
pip install altimate-datapilot-cliorpip install altimate_datapilot_clibecause PyPI normalizes package namesTest Plan
version-bumplabel🤖 Generated with Claude Code
Important
Change package name in
setup.pyto use underscores, resolving PyPI filename error.setup.pyfromaltimate-datapilot-clitoaltimate_datapilot_clito comply with PyPI requirements.This description was created by
for 0985ae6. You can customize this summary. It will automatically update as commits are pushed.