Conversation
The tag-release workflow was failing because the pre-installed setuptools (65.5.0) doesn't normalize package names to underscores when creating source distributions. This caused PyPI to reject the tarball with error: 'Filename altimate-datapilot-cli-0.1.1.tar.gz is invalid, should be altimate_datapilot_cli-0.1.1.tar.gz'. Modern setuptools (65.6.0+) automatically normalize package names. Adding --upgrade flag ensures we get the latest version that handles name normalization correctly. Impact: This will allow both wheel and source distributions to upload successfully to PyPI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7077c5b in 24 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/tag-release.yml:28
- Draft comment:
Adding '--upgrade' flag ensures setuptools (and others) are updated so package names are normalized correctly. Looks good. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_LQqjhoBAHdF7rBKF
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
suryaiyer95
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--upgradeflag when installing setuptools in the tag-release workflowProblem
The tag-release workflow was partially failing during PyPI upload:
altimate_datapilot_cli-0.1.1-py3-none-any.whlaltimate-datapilot-cli-0.1.1.tar.gzError from PyPI:
Root Cause
Solution
Changed:
pip install tox twine wheel setuptoolsTo:
pip install --upgrade tox twine wheel setuptoolsThis ensures setuptools is upgraded to the latest version which correctly normalizes:
altimate-datapilot-cli→altimate_datapilot_cli(for filenames)Local Verification
Tested locally to confirm the issue and fix:
❌ With setuptools 65.5.0 (mimicking GitHub Actions environment)
✅ After pip install --upgrade setuptools (80.9.0)
Result: Confirmed that upgrading setuptools fixes the filename normalization issue.
Impact
pip install altimate-datapilot-cliorpip install altimate_datapilot_cliVerification
You can verify the current state:
🤖 Generated with Claude Code