Skip to content

allow extra fields in several classes in catalog_v1.py #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdesmet merged 2 commits into from
Nov 6, 2025
Merged

allow extra fields in several classes in catalog_v1.py #85

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec52df0
added field invocation_started_at in catalog validation
Sourabhchrs93 Nov 5, 2025
3d03aaa
allow additional field in catalog json files
Sourabhchrs93 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vendor/dbt_artifacts_parser/parsers/catalog/catalog_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class Metadata(BaseParserModel):
dbt_version: Optional[str] = "1.9.0b2"
generated_at: Optional[str] = None
invocation_id: Optional[str] = None
invocation_started_at: Optional[str] = None
Copy link
Collaborator

@mdesmet mdesmet Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also allow extra fields? Seems dbt keeps adding fields.

Copy link
Contributor Author

@Sourabhchrs93 Sourabhchrs93 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should. Currently job fails whenever new fields are added.

Copy link
Contributor

@jontsai jontsai Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the @mdesmet's suggestion is to consider allowing extra fields, and only explicitly defining the fields which we actually use.

So, instead of adding a single field, the recommendation would be to change line 17-19 above:

    model_config = ConfigDict(
-        extra="forbid",
+        extra="allow",
    )

Do we know if there was a reason for setting extra="forbid" in the first place, and any reason preventing this change?

Reference:

env: Optional[dict[str, str]] = None


Expand Down
Loading