Add changelog entries and bump versions for 0.10.0 release#194
Merged
bors[bot] merged 4 commits intoAmanieu:masterfrom Nov 25, 2019
Merged
Add changelog entries and bump versions for 0.10.0 release#194bors[bot] merged 4 commits intoAmanieu:masterfrom
bors[bot] merged 4 commits intoAmanieu:masterfrom
Conversation
Collaborator
Author
|
Except for the tiny |
faern
commented
Nov 24, 2019
| [dependencies] | ||
| parking_lot_core = { path = "core", version = "0.6.2" } | ||
| parking_lot_core = { path = "core", version = "0.7.0" } | ||
| lock_api = { path = "lock_api", version = "0.3.1" } |
Collaborator
Author
There was a problem hiding this comment.
I'm not bumping the dependency on lock_api here. Because the new parking_lot does not need the new release. It's just some documentation fixes.
Amanieu
reviewed
Nov 24, 2019
faern
force-pushed
the
prepare-release
branch
from
6003602 to
f2b21e1
Compare
faern
force-pushed
the
prepare-release
branch
from
db5dc1c to
84a6f27
Compare
Owner
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
194: Add changelog entries and bump versions for 0.10.0 release r=Amanieu a=faern We must first let #193 be merged. Otherwise this changelog is not even correct. There were a lot of changes since last release. But the vast majority is reformatting and re-arranging to reduce the number of unsafe expressions. As well as adding safety invariant documentation and a few tests. These are cool improvements, but does not affect the public API. I can add something about it in the changelog if you think it's worth it. `lock_api` only has formatting changes and a few documentation improvements, so I don't think it needs a breaking version change. But might be worth releasing anyway to get the improved documentation out. The date in the changelog is simply tomorrow. Since I did not think we would have time to release today, and I did not want to just go with `2019-XX-YY` either. If we don't think we'll release tomorrow we can just fix that before merging this PR. Co-authored-by: Linus Färnstrand <faern@faern.net>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must first let #193 be merged. Otherwise this changelog is not even correct.
There were a lot of changes since last release. But the vast majority is reformatting and re-arranging to reduce the number of unsafe expressions. As well as adding safety invariant documentation and a few tests. These are cool improvements, but does not affect the public API. I can add something about it in the changelog if you think it's worth it.
lock_apionly has formatting changes and a few documentation improvements, so I don't think it needs a breaking version change. But might be worth releasing anyway to get the improved documentation out.The date in the changelog is simply tomorrow. Since I did not think we would have time to release today, and I did not want to just go with
2019-XX-YYeither. If we don't think we'll release tomorrow we can just fix that before merging this PR.