Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wtf ja 101 01 #737

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

PolymetisOutis
Copy link

@PolymetisOutis PolymetisOutis commented Jun 2, 2024

What type of PR is this (这是什么类型的PR)

  • Typo(勘误)
  • BUG(程序错误)
  • Improvement(提升)
  • Feature(新特性)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

  • resolve(修复) : #

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

@PolymetisOutis
Copy link
Author

Hi, I am trying to add Japanese version with @thurendous , and now I want to make a pull request about
just 101-01_HelloWeb3_ja as a test.

@thurendous
Copy link
Contributor

We are working together on this now. Thanks! @PolymetisOutis
I am working on Solidity 102 and he is on Solidity 101.

@AmazingAng
Copy link
Owner

lfg!

@PolymetisOutis
Copy link
Author

May I have a talk a bit?? @AmazingAng
https://www.wtf.academy/docs/solidity-101/HelloWeb3/
In this page, I think "第二个条件由^提供" must be "第一个条件由^提供", i.e. "the first condition is provided by ^".
Through some discussion with @thurendous , it comes to end in my misunderstanding, but in my opinion about reading comprehension I think still it's appropriate that "first condition" means "more than v0.8.4" and "second condition" means "less than v0.9.0" in the following sentence, i.e. v0.8.4 ≦ version < v0.9.0:"The second line declares the Solidity version used by the source file, because the syntax of different versions is different. This line of code means that the source file will not allow compilation by compilers version lower than v0.8.4 and not higher than v0.9.0"
So, I want to recommend "first condition" may fit. How about that?

@AmazingAng
Copy link
Owner

are they ready for merge?

@AmazingAng
Copy link
Owner

May I have a talk a bit?? @AmazingAng https://www.wtf.academy/docs/solidity-101/HelloWeb3/ In this page, I think "第二个条件由^提供" must be "第一个条件由^提供", i.e. "the first condition is provided by ^". Through some discussion with @thurendous , it comes to end in my misunderstanding, but in my opinion about reading comprehension I think still it's appropriate that "first condition" means "more than v0.8.4" and "second condition" means "less than v0.9.0" in the following sentence, i.e. v0.8.4 ≦ version < v0.9.0:"The second line declares the Solidity version used by the source file, because the syntax of different versions is different. This line of code means that the source file will not allow compilation by compilers version lower than v0.8.4 and not higher than v0.9.0" So, I want to recommend "first condition" may fit. How about that?

I think you are right. ^ symbol in Solidity indicates compatibility with the specified version and any higher versions, but not including the next major version.

Also, the contents on wtf.academy website may not be the most updated version, please refer to GitHub repo when translating. Thank you!

@PolymetisOutis
Copy link
Author

PolymetisOutis commented Jun 23, 2024

@AmazingAng
Thank you for your reply! :D

I think you are right.

OK, thank you so much,
I’ve already reflected it to the latest PR version.

Also, the contents on wtf.academy website may not be the most updated version, please refer to GitHub repo when translating.

OK, I've also checked them.

are they ready for merge?

Yeah, so sure, I'm ready!
Please merge, let's get started!! CC:@thurendous

@PolymetisOutis
Copy link
Author

PolymetisOutis commented Jun 23, 2024

now I am working in progress about 101-06 to 101-08. Only 8-1 and 8-2 png picture editting left. :▷
CC: @thurendous

@PolymetisOutis
Copy link
Author

@AmazingAng
Now PR commit of 101-06 to 101-08 lecture has been done!!
Please note that some explanations are added to the each article in some places for beginner's guide to understand the meaning of the expressions!!
best regards, CC: @thurendous

@PolymetisOutis
Copy link
Author

@AmazingAng CC: @thurendous
Now, 101-09 to 101-11 lecture ja version added!!
Thanks for everything!! :D

@AmazingAng
Copy link
Owner

@AmazingAng CC: @thurendous Now, 101-09 to 101-11 lecture ja version added!! Thanks for everything!! :D

wow, this is great!
Shall I merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants