Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / Claim Wallet Rewards #850

Open
wants to merge 9 commits into
base: v2
Choose a base branch
from
Open

Feature / Claim Wallet Rewards #850

wants to merge 9 commits into from

Conversation

gergana95
Copy link
Member

@gergana95 gergana95 commented Jul 3, 2024 •
edited
Loading

Create sign account op function in transfer helpers to claim wallet rewards.

@gergana95 gergana95 self-assigned this Jul 3, 2024
Ivshti
Ivshti requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Ivshti Ivshti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think mainCtrl should get even more cluttered than it is and gain functionalities like this - let's think of a better solution

PetromirDev
PetromirDev requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@PetromirDev PetromirDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

src/controllers/main/main.ts Outdated Show resolved Hide resolved
src/libs/portfolio/interfaces.ts Outdated Show resolved Hide resolved
src/libs/transfer/userRequest.ts Outdated Show resolved Hide resolved
src/libs/transfer/userRequest.ts Outdated Show resolved Hide resolved
@superKalo superKalo mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetromirDev PetromirDev Awaiting requested review from PetromirDev

@Ivshti Ivshti Awaiting requested review from Ivshti

Assignees

@gergana95 gergana95

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gergana95 @Ivshti @PetromirDev