Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created remember the last used folder option #57

Merged

Conversation

GalievBulat
Copy link
Contributor

Remember the last used folder when adding new link option

@GalievBulat
Copy link
Contributor Author

Hello @AmrDeveloper I've implemented the requested feature, so please check it out

Copy link
Owner

@AmrDeveloper AmrDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me everything is good, just need to make two small changes

@@ -31,6 +31,7 @@
<string name="import_export_choose_file_type">Choose a file type</string>
<string name="password">Password</string>
<string name="enable_password">Enable password</string>
<string name="default_folder">Remember the last used folder as default one</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find translations for other langs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I use google translate to translate this line to all the other languages?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I use google translate to translate this line to all the other languages?

For now yes, and can we make it shorter than Remember the last used folder as default one, hmmm maybe Enable Remember Folder or Remember last folder what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what's right, "Remember the last folder" in my opinion would be fine

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great let's go with it

@@ -55,6 +55,9 @@ class SettingFragment : Fragment() {

// Setup Auto saving
binding.autoSavingSwitch.isChecked = uiPreferences.isAutoSavingEnabled()

// Setup Auto saving
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, Fix this comment to be // Setup default folder

@GalievBulat
Copy link
Contributor Author

Hello, @AmrDeveloper, I've resolved the commented changes . So please check it out

@AmrDeveloper
Copy link
Owner

Looks great, Thank you

@AmrDeveloper AmrDeveloper merged commit 75dc82b into AmrDeveloper:master Apr 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants