Implemented private variable obfuscation and improved the pyinstaller spec file. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method required importing the modules to inspect the path attribute. The new method gets the path using importlib without importing it.
It would be useful to be able to stop third party code poking around in private variables. Python does not have true private variables but we can get close by obfuscating the private variable names. Python does have double underscore attributes and methods but these are not available in first party subclasses so are not very useful in a lot of cases. True obfuscation would be difficult and require tracking variables across modules. This implementation is much simpler and just prefixes all private variables with the same random string.
The obfuscation will also rename _[a-zA-Z0-9_] in the import path. The file paths also need obfuscating to fix this
Fixed issues with files through symbolic links. Fixed makedirs bug. Fixed glob directory bug. Removed pymct obfuscation. Due to dynamic private attribute access it cannot currently be obfuscated. This should get fixed in the future though.
|
|
Podshot
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved code finding module paths. No longer need to import the packages.
Added code to obfuscate private variables (variables starting with a single underscore) so that third parties cannot access or edit the private state.