Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode search #4

Closed

Conversation

jopemachine
Copy link

Issue

  • Unicode search not supported

Change

  • Support unicode search (using normalize)

Before

Screen Shot 2020-08-23 12 46 01

After

Screen Shot 2020-08-23 12 44 34

Note

I think unicode searching would be useful.

@AnNOtis
Copy link
Owner

AnNOtis commented Sep 13, 2020

@jopemachine

Thanks for your time and effort.

I've tested other texts with different code points, it seems normalize is not needed. However, I didn't use the chars in your screenshot for testing, because I have no idea how to type Korean 😂. Could you provide the text in your notion and your search term, so I can reproduce it?

@jopemachine
Copy link
Author

jopemachine commented Sep 13, 2020

@jopemachine

Thanks for your time and effort.

I've tested other texts with different code points, it seems normalize is not needed. However, I didn't use the chars in your screenshot for testing, because I have no idea how to type Korean 😂. Could you provide the text in your notion and your search term, so I can reproduce it?

Thank you for your time.

You can reproduce it by ns 이미지

But I think maybe you don't have the note containing the word (이미지).

So, I think it is okay to make a note containing the word by copying and paste and reproduce.

I think then you can know that the note will not be retrieved when normalize is not used.

@jopemachine
Copy link
Author

Closed due to no reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants