Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync upcoming events component with API and hack work around for apos… #46

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Oct 18, 2022

Related Issue

related to #16

Summary of Changes

  1. Updated mock events to match API response structure
  2. Update tests and story accordingly
  3. Implemented ugly hack to work around ' in JSON - improve current solution for serializing JSON in HTML #47

@thescientist13 thescientist13 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 18, 2022
@thescientist13 thescientist13 added this to the Website v1.0 milestone Oct 18, 2022
@thescientist13 thescientist13 merged commit c13032d into v1 Oct 20, 2022
@thescientist13 thescientist13 deleted the bug/issue-16-handling-escaping-and-api-compliance branch October 20, 2022 12:43
@thescientist13 thescientist13 linked an issue Oct 20, 2022 that may be closed by this pull request
4 tasks
thescientist13 added a commit that referenced this pull request Oct 25, 2022
#46)

* sync upcoming events component with API and hack work around for apostrophes in JSON

* track hack work around
@thescientist13 thescientist13 self-assigned this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upcoming Episode / Schedule
1 participant