#168137051 Implement component for avatar and avatar-group #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luckzman
force-pushed
the
ft-create-avatar-component-168137051
branch
2 times, most recently
from
5c899e9
to
6e4666e
Compare
oluwajuwon
reviewed
Aug 30, 2019
There was a problem hiding this comment.
nice work @Luckzman
Please have a look at the comment and also kindly change your PR title to adhere to the team's convention
| * @param {object} { imgUrl, classes, altText } | ||
| * @returns JSX | ||
| */ | ||
| export default function Avatar({ imgUrl, classes, altText }) { |
There was a problem hiding this comment.
any reason why you're not using the fat arrow method?
Luckzman
changed the title
- Implement component for avatar - Implement component for avatar group - Style both avatar and avatar group component [#168137051]
Luckzman
force-pushed
the
ft-create-avatar-component-168137051
branch
6 times, most recently
from
b52d4a6
to
c00c5e4
Compare
Luckzman
force-pushed
the
ft-create-avatar-component-168137051
branch
from
c00c5e4
to
5bbda24
Compare
Luckzman
added
frontend
Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do?
This PR creates Avatar and AvatarGroup Component
Description Of Task To Be Completed
Any Background Context You Want To Provide?
How can this be manually tested?
What are the relevant pivotal tracker stories?
#168137051
Screenshot(s)