Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168261941 Test the normalize_dates helper function #272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MandelaK
Copy link
Collaborator

@MandelaK MandelaK commented Sep 9, 2019

What Does This PR Do?

Test the helper function that normalizes dates.

Description Of Task To Be Completed

The helper function should be tested so that future changes to the code don't break its functionality.

Any Background Context You Want To Provide?

The helper function ensures that event dates are not set in the past or that the events end only after they begin.

How can this be manually tested?

Run tests and ascertain that the helper function is fully tested by coverage.

What are the relevant pivotal tracker stories?

#168261941

Screenshot(s)

N/A

@MandelaK MandelaK added backend Ready for review the pr is ready for review labels Sep 9, 2019
@MandelaK MandelaK force-pushed the ch-unittest-normalize-dates-168261941 branch 3 times, most recently from b63d676 to 8390fff Compare September 12, 2019 09:37
- Test that the `validate_dates` function works if dates are correct or wrong
- Fix issue with past dates. Now we always use current dates in the tests

[Finishes #168261941]
@MandelaK MandelaK force-pushed the ch-unittest-normalize-dates-168261941 branch from 8390fff to f378a08 Compare September 12, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ready for review the pr is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant