Merge pull request #204 from AndreaPontrandolfo/AndreaPontrandolfo/is…

…sue177 feat(deps): update `@typescript-eslint/eslint-plugin` to latest
AndreaPontrandolfo · Aug 12, 2024 · 9a66082 · 9a66082
2 parents 673ce08 + fc4e0e5
commit 9a66082
Show file tree

Hide file tree

Showing 9 changed files with 154 additions and 127 deletions.
diff --git a/.changeset/two-pigs-wash.md b/.changeset/two-pigs-wash.md
@@ -0,0 +1,7 @@
+---
+'eslint-config-sheriff': patch
+'sheriff-webservices': patch
+---
+
+feat(deps): update @typescript-eslint/eslint-plugin to latest
+Fixes #177
diff --git a/apps/sheriff-webservices/.typesyncrc.json b/apps/sheriff-webservices/.typesyncrc.json
@@ -4,7 +4,6 @@
     "create-sheriff-config",
     "@sherifforg/types",
     "eslint-config-sheriff",
-    "@eslint/js",
     "eslint"
   ]
 }
diff --git a/apps/sheriff-webservices/package.json b/apps/sheriff-webservices/package.json
@@ -17,6 +17,7 @@
     "@sherifforg/types": "workspace:*",
     "@tsconfig/node-lts": "^18.12.5",
     "@types/eslint-plugin-jsx-a11y": "^6.9.0",
+    "@types/eslint__js": "^8.42.3",
     "@types/lodash": "^4.17.6",
     "@types/node": "^20.14.10",
     "eslint-define-config": "^2.1.0",
@@ -53,7 +54,7 @@
     "eslint-plugin-vitest": "^0.3.26",
     "hono": "^3.12.0",
     "lodash": "^4.17.21",
-    "typescript-eslint": "^7.8.0"
+    "typescript-eslint": "^8.0.1"
   },
   "packageManager": "[email protected]",
   "engines": {

diff --git a/packages/eslint-config-sheriff/.typesyncrc.json b/packages/eslint-config-sheriff/.typesyncrc.json
@@ -4,7 +4,6 @@
     "create-sheriff-config",
     "@sherifforg/types",
     "eslint-config-sheriff",
-    "@eslint/js",
     "eslint"
   ]
 }
diff --git a/packages/eslint-config-sheriff/package.json b/packages/eslint-config-sheriff/package.json
@@ -82,7 +82,7 @@
     "eslint-plugin-unicorn": "^55.0.0",
     "eslint-plugin-vitest": "^0.3.26",
     "globals": "^15.9.0",
-    "typescript-eslint": "^7.8.0"
+    "typescript-eslint": "^8.0.1"
   },
   "peerDependencies": {
     "eslint": "8.38.0 - 8.57.0 || 8.57.0-0",
@@ -97,9 +97,10 @@
     "@sherifforg/constants": "workspace:*",
     "@sherifforg/types": "workspace:*",
     "@types/eslint-plugin-jsx-a11y": "^6.9.0",
+    "@types/eslint__js": "^8.42.3",
     "@types/lodash": "^4.17.6",
     "@types/node": "^20.14.10",
-    "@typescript-eslint/utils": "^7.3.1",
+    "@typescript-eslint/utils": "^8.0.1",
     "eslint": "^8.57.0",
     "eslint-define-config": "^2.1.0",
     "lodash": "^4.17.21",

diff --git a/packages/eslint-config-sheriff/src/getBaseConfig.ts b/packages/eslint-config-sheriff/src/getBaseConfig.ts
@@ -40,19 +40,16 @@ export const getBaseConfig = (
       // @ts-expect-error
       rules: getBaseEslintHandPickedRules(),
     },
-    {
-      files: [`**/*{${allJsExtensions}}`],
-      languageOptions: getLanguageOptionsTypescript(customTSConfigPath),
-    },
     {
       files: [supportedFileTypes],
       extends: tseslint.configs.strictTypeChecked,
     },
+    {
+      files: [`**/*{${allJsExtensions}}`],
+      languageOptions: getLanguageOptionsTypescript(customTSConfigPath),
+    },
     {
       files: [supportedFileTypes],
-      plugins: {
-        '@typescript-eslint': tseslint.plugin,
-      },
       rules: {
         ...typescriptHandPickedRules,
         ...getTsNamingConventionRule({ isTsx: false }),

diff --git a/packages/eslint-config-sheriff/src/handledModules.d.ts b/packages/eslint-config-sheriff/src/handledModules.d.ts
@@ -1,4 +1,3 @@
-declare module '@eslint/js';
 declare module '@next/eslint-plugin-next';
 declare module '@regru/eslint-plugin-prefer-early-return';
 declare module 'eslint-plugin-lodash-f';

diff --git a/packages/eslint-config-sheriff/src/handpickedRules/typescriptHandPickedRules.ts b/packages/eslint-config-sheriff/src/handpickedRules/typescriptHandPickedRules.ts
@@ -1,8 +1,17 @@
 export const typescriptHandPickedRules = {
-  '@typescript-eslint/ban-ts-comment': 0,
   '@typescript-eslint/no-unsafe-assignment': 0,
   '@typescript-eslint/no-array-constructor': 0,
   '@typescript-eslint/use-unknown-in-catch-callback-variable': 0,
+  '@typescript-eslint/no-require-imports': 0, // eventually we will enable https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-module.md instead
+  '@typescript-eslint/ban-ts-comment': [
+    2,
+    {
+      'ts-expect-error': false,
+      'ts-ignore': true,
+      'ts-nocheck': false,
+      'ts-check': false,
+    },
+  ],
   '@typescript-eslint/no-use-before-define': 2,
   '@typescript-eslint/no-inferrable-types': 2,
   '@typescript-eslint/no-loop-func': 2,