-
Notifications
You must be signed in to change notification settings - Fork 7
1.21.1 Update #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TriibuNupsik
wants to merge
74
commits into
Andrew6rant:main
Choose a base branch
from
TriibuNupsik:1.21.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.21.1 Update #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix UV's for vertical north/south top slabs
if you shift while mining a double slab, you can break both sides of it at once. Also fixed bug where the block breaking overlay was misaligned
- Enable it by default (can always be disabled by user - Fix prismarine slabs not getting textures applied - Add custom textures to vertical sandstone and red sandstone slabs
moved blockstate setup into util function fixed statement logspam fixed runtime resource pack not being auto-enabled
Statement API changed from using `org.apache.logging.log4j.Logger` to `org.spongepowered.asm.logging.ILogger`. I can no longer change the level of the logger programmatically, so I have to use a different method (making a mixin that runs before theirs)
everything works!
also embed custom ARRP fork and Statement 4.2.8
no functionality yet
also added a config option to disable enhanced slab placement rendering + switched some slab overrides to inject mixins for better compatibility
right now it shows all the time dependent on the placement state, I want it to only show when the player is holding a slab block
yes, I know this code is atrocious, but it works. I'll clean it up later.
I know this code is really messy haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rotate()andmirror()for vertical slabs #35Would be nice to have 1.21 branch