chore: switch to pipenv and clean up packages #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewADev
changed the title
AndrewADev
force-pushed
the
chore/convert-to-pipenv
branch
from
a56d838
to
c39f5c5
Compare
Install requirements based on previous requirements.txt, relaxing the pyparsing version constraint so that the install succeeds (was causing resolution issue).
Go through and upgrade these, leaving exact versions to lockfile for now.
A few of these are known previous subdependencies that are no longer needed. Some might be from initial generation (unneeded packages from mixed env). In any case, tests and program now runs fine without them.
Split out dependencies known to be development-only, as well as any unambiguous sub-dependenvies (determined via `pipenv graph`)
AndrewADev
force-pushed
the
chore/convert-to-pipenv
branch
from
c39f5c5
to
078f817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install requirements based on previous requirements.txt, converting to non-constrained versions in Pipenv.
Also upgrade all packages, remove those no longer needed, as well as split out known dev dependencies.