Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add type annotations and type checking #36

Merged
merged 2 commits into from
Aug 13, 2023
Merged

chore: add type annotations and type checking #36

merged 2 commits into from
Aug 13, 2023

Commits on Aug 13, 2023

  1. chore: add type annotations and type checking 

    Add type hinting, and use mypy to perform type checking as part of the CI checks.
    @AndrewADev
    AndrewADev committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    b9ea7ea View commit details
    Browse the repository at this point in the history

  2. fix: NameError for self reference in method 

    Fix an issue where referencing the class as a type caused a NameError.

We do this by allowing forward references, see here: https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html#forward-references
    @AndrewADev
    AndrewADev committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    dec3c8a View commit details
    Browse the repository at this point in the history