Skip to content

An 170 coordinate tx wallet support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: AN-118-coordinate-upgrade
Choose a base branch
from
Open

An 170 coordinate tx wallet support #2

wants to merge 9 commits into from

Conversation

sucildossj
Copy link

Included following changes

scantxoutset rpc changes for asset
listunspent rpc changes for asset
create premium transaction rpc
send asset transaction rpc
send pegout transaction rpc

@sucildossj sucildossj requested a review from jasonribble October 1, 2025 14:32
jasonribble
jasonribble approved these changes Oct 1, 2025
View reviewed changes
Copy link

@jasonribble jasonribble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to keep formatting from upstream to reduce merge conflict in the future

jasonribble
jasonribble approved these changes Oct 9, 2025
View reviewed changes
Copy link

@jasonribble jasonribble left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CAsset in the outpoint looks looks good

@sucildossj
Copy link
Author

sucildossj commented Oct 9, 2025 •
edited
Loading

The CAsset in the outpoint looks looks good
Currently, I’m changing the data type to a buffer that holds 8 bytes (int64_t) for the block number and 2 bytes (int16_t) for the asset number within the block. Each block can have only 256 new assets, with asset IDs ranging from 001 to 256. We need to filter the block template to allow only 256 assets per block and ensure this rule is validated in the consensus layer as well. @jasonribble

@sucildossj
Copy link
Author

Additionally, if an asset creation transaction is still in the mempool, we need to wait until it is confirmed before allowing any transfers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonribble jasonribble jasonribble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sucildossj @jasonribble