-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Add LadybugDB installation checks and platform-specific memory paths #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mateuszruszkowski
wants to merge
13
commits into
AndyMik90:develop
Choose a base branch
from
mateuszruszkowski:fix/windows-path-and-terminal-scaling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+746
−81
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d3c6ecc
fix(platform): use platform-specific paths for memory settings on Win…
mateuszruszkowski 101cb0c
feat(memory): add LadybugDB installation detection with helpful error…
mateuszruszkowski 4e3b928
fix(terminal): add PowerShell call operator for command execution
mateuszruszkowski 29dbac3
fix(terminal): address PR #1262 review comments
mateuszruszkowski 25d4165
refactor: extract DPI font helper, add PowerShell support, and improv…
mateuszruszkowski 865e81e
refactor(frontend): extract useMemoriesDir hook and fix DPI change ha…
mateuszruszkowski b29895c
fix(frontend): address PR review feedback for hooks and i18n
mateuszruszkowski dfec834
fix: address remaining CodeRabbit review comments
mateuszruszkowski 909726e
perf: convert checkLadybugInstalled to async to prevent UI freeze
mateuszruszkowski 788135b
fix(i18n): use i18n keys for error messages and fix pythonAvailable l…
mateuszruszkowski 8b46c7d
fix(memory): check Python availability in sync wrapper before returni…
mateuszruszkowski 91e7307
fix(i18n): remove duplicate keys and align naming convention
mateuszruszkowski 1ec7237
fix(security): stop execution if PowerShell Remove-Item fails
mateuszruszkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 17230
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 3211
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 109
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 3535
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 1914
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 1954
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 2442
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 2477
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 760
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 2116
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 3877
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 744
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 1214
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 209
Use
getBackendPythonPath()for the install check to match memory query resolution.In development mode,
findPythonCommand()(line 793) may resolve to system Python withoutreal_ladybuginstalled, while memory queries correctly usegetBackendPythonPath()to find the backend venv that includes the package. This causes the install check to fail even when memory queries work (false negative). Since the check attempts toimport real_ladybug, it must use the same resolver as the actual queries.Replace
findPythonCommand()withgetBackendPythonPath()at line 793. Note thatgetBackendPythonPath()always returns a string and never null, so the null check at lines 794–800 can be removed.Also apply the same fix at lines 954 and 982 where
pythonAvailableusesfindPythonCommand()for status reporting.🤖 Prompt for AI Agents