Skip to content

fix(frontend): quote Claude CLI paths containing spaces on Windows #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StillKnotKnown wants to merge 24 commits into from

refactor: remove temp file cleanup race conditions and fix test lifec…

af2e196
Select commit
Loading
Failed to load commit list.
Closed

fix(frontend): quote Claude CLI paths containing spaces on Windows #841

refactor: remove temp file cleanup race conditions and fix test lifec…
af2e196
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jan 10, 2026 in 1s

9 new alerts including 3 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 3 medium

Other Alerts:

  • 6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 943 in apps/frontend/src/main/cli-tool-manager.ts

See this annotation in the file changed.

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
file name
Loading
.

Check warning on line 943 in apps/frontend/src/main/cli-tool-manager.ts

See this annotation in the file changed.

Code scanning / CodeQL

Indirect uncontrolled command line Medium

This command depends on an unsanitized
environment variable
Loading
.

Check warning on line 1056 in apps/frontend/src/main/cli-tool-manager.ts

See this annotation in the file changed.

Code scanning / CodeQL

Indirect uncontrolled command line Medium

This command depends on an unsanitized
environment variable
Loading
.

Check notice on line 70 in apps/frontend/src/__tests__/integration/terminal-copy-paste.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origRequestAnimationFrame.

Check notice on line 71 in apps/frontend/src/__tests__/integration/terminal-copy-paste.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origCancelAnimationFrame.

Check notice on line 72 in apps/frontend/src/__tests__/integration/terminal-copy-paste.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origResizeObserver.

Check notice on line 87 in apps/frontend/src/renderer/components/terminal/__tests__/useXterm.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origRequestAnimationFrame.

Check notice on line 88 in apps/frontend/src/renderer/components/terminal/__tests__/useXterm.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origCancelAnimationFrame.

Check notice on line 89 in apps/frontend/src/renderer/components/terminal/__tests__/useXterm.test.ts

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable origResizeObserver.