refactor(ranker): split ranking helpers into focused modules - #145
Open
RaghavRD wants to merge 1 commit into
Open
refactor(ranker): split ranking helpers into focused modules#145RaghavRD wants to merge 1 commit into
RaghavRD wants to merge 1 commit into
Conversation
Move ranking orchestration, filters, quality scoring, source trust constants, and candidate variant selection into focused modules. Keep whichllm.engine.ranker as a compatibility shim so existing public and test imports continue to work. Refs Andyyyy64#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ranking orchestration, filters, quality scoring, source trust constants, and candidate variant selection into focused modules.
Keep
whichllm.engine.rankeras a compatibility shim so existing public and test imports continue to work.Refs #41
What
rank_modelsorchestration intowhichllm.engine.rankingranking_filtersranking_scoreranking_sourcesranking_variantswhichllm.engine.rankerWhy
This continues the #41 core-module refactor by splitting the large ranker module into focused pieces without changing the public import surface.
This is the penultimate major #41 refactor slice. After this, the remaining large core module is
src/whichllm/cli.py.Testing
74 passed)6 passed)465 passed, 1 deselected)Notes
Full
pytestin my sandbox hittest_run_exits_gracefullybecause model fetching returned a DNS/network error message from the environment. The ranker-specific and compatibility coverage passes.