Skip to content

Commit

Permalink
Fix dns ignore error field (#4)
Browse files Browse the repository at this point in the history
* [FIX] Fixed ServiceAddPrincipal condition when ignoreError in Issuer is true
---------

Co-authored-by: anghille <[email protected]>
  • Loading branch information
Anghille and anghille authored Jun 22, 2023
1 parent de8a82e commit e1206d0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions provisionners/freeipa.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,6 @@ func (s *FreeIPAPKI) Sign(ctx context.Context, cr *certmanager.CertificateReques
&freeipa.ServiceAddPrincipalArgs{Krbcanonicalname: name, Krbprincipalname: csr.DNSNames},
&freeipa.ServiceAddPrincipalOptionalArgs{}); err != nil && !s.spec.IgnoreError {
return nil, nil, fmt.Errorf("fail adding DNSNames SAN principal to the service %v : %v", name, err)
} else if err != nil && s.spec.IgnoreError {
log.Error(err, "Ignored Error> Failed to add DNSNames SAN principal to the service")
} else {
log.Info("Added DNSNames SAN principal to the service", "service", name)
}
Expand Down

0 comments on commit e1206d0

Please sign in to comment.