Skip to content
This repository has been archived by the owner on Jul 14, 2024. It is now read-only.

added characters card #77

Merged
merged 5 commits into from
Sep 23, 2023
Merged

added characters card #77

merged 5 commits into from
Sep 23, 2023

Conversation

Aijazmakerb
Copy link
Contributor

added chracters section area in details page, hope you will like it

@DevanAbinaya
Copy link
Collaborator

Hi! Thanks for the PR. I'll take a look at it later this afternoon. :)

Copy link
Collaborator

@DevanAbinaya DevanAbinaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
Just need a slight change to the code, after that I'll start merging.

components/anime/charactersCard.js Outdated Show resolved Hide resolved
pages/en/anime/[...id].js Outdated Show resolved Hide resolved
@Aijazmakerb
Copy link
Contributor Author

Thanks for the suggestions.

@DevanAbinaya
Copy link
Collaborator

and also once more,
could you update release.md and package.json version?

release.md:

# Changelog

This document contains a summary of all significant changes made to this release.

## 🎉 Update v4.0.5

### Added

- Added characters card to info page

package.json:

"version": "4.0.5",

Copy link
Collaborator

@DevanAbinaya DevanAbinaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@DevanAbinaya
Copy link
Collaborator

great, I will start merging, thanks for your contributions. If you have any suggestion or idea you want to contribute, feel free to open pull request :)

@DevanAbinaya DevanAbinaya merged commit 58eacce into Ani-Moopa:main Sep 23, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants