Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: request rate reduction #646

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Conversation

wax911
Copy link
Member

@wax911 wax911 commented Mar 24, 2024

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure you've done the following:

  • You have followed our contributing guidelines
  • Double checked that your branch is based on develop and targets develop (where applicable)
  • Pull request has tests (if applicable)
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved

Description

  • It seems that AniList has reduced the rate limit to 15 req/minute this seems true for queries and mutations generally and this has led to a bunch of rate limits as we had made some decisions around preferring utilising more memory in exchange for offset requests. This wasn't an issue before as the API was rate limited to 90 req/minute

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@github-actions github-actions bot added the docs label Mar 24, 2024
@wax911 wax911 force-pushed the refactor/request-rate-reduction branch from 1d63fde to 19f9e77 Compare March 24, 2024 10:40
@wax911 wax911 added the enhancement Improves exiting functionality label Mar 24, 2024
@wax911 wax911 force-pushed the develop branch 2 times, most recently from ede6aa1 to 409d43e Compare March 24, 2024 11:25
@wax911 wax911 force-pushed the refactor/request-rate-reduction branch from 19f9e77 to fddc8eb Compare March 24, 2024 11:32
@wax911 wax911 requested a review from luk1337 March 24, 2024 11:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved automated PR

@luk1337
Copy link
Member

luk1337 commented Mar 24, 2024

Can we do this instead of repeating getViewModel().snapshot()?

0001-Add-ActivityBase-getModel.PATCH

@wax911
Copy link
Member Author

wax911 commented Mar 24, 2024

Can we do this instead of repeating getViewModel().snapshot()?

0001-Add-ActivityBase-getModel.PATCH

I like this better, I'll add the patch and push

@wax911 wax911 merged commit 3a20994 into develop Mar 25, 2024
8 checks passed
@wax911 wax911 deleted the refactor/request-rate-reduction branch March 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement Improves exiting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants