Skip to content

Commit

Permalink
[IndexTable.Row] Revert selectable=false early return, which break on… (
Browse files Browse the repository at this point in the history
Shopify#11773)

### WHAT is this pull request doing?

This PR reverts a change made in Shopify#11763, unrelated to the bug fixed,
that caused an unintended regression: breaking `onNavigation` behavior
for unselectable tables. This needs to ship in a patch asap because it
is live in v12.20.0.
  • Loading branch information
chloerice authored Mar 21, 2024
1 parent 21bf7cd commit 4c38f43
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/real-papayas-tease.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Reverted a change that caused `IndexTable` `onNavigation` not to work when `selectable` is `false`
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const Row = memo(function Row({
return;
}

if (primaryLinkElement.current && !selectMode && selectable) {
if (primaryLinkElement.current && !selectMode) {
isNavigating.current = true;
const {ctrlKey, metaKey} = event.nativeEvent;

Expand Down

0 comments on commit 4c38f43

Please sign in to comment.