Skip to content

Commit

Permalink
[polaris.shopify.com] Fix broken images (Shopify#11741)
Browse files Browse the repository at this point in the history
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?

Fixes some broken images in the Guidance for `Modal` and `Setting
toggle`.
  • Loading branch information
tjonx authored Mar 15, 2024
1 parent a8ceec1 commit 5d4742a
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,6 @@ The setting toggle component should only be used when:

If the setting is dependent on other settings, uses progressive disclosure, or has options that are not a simple “On”/“Off”, use a different UI element such as [Checkbox](https://polaris.shopify.com/components/selection-and-input/checkbox) or [Radio button](https://polaris.shopify.com/components/selection-and-input/radio-button).

<DoDont>

#### Do

Only include the actions Turn on/ Turn off.

![Setting toggle do](/images/components/deprecated/setting-toggle/Do.png)

#### Don’t

Don't include additional settings or inputs.

![Setting toggle dont](/images/components/deprecated/setting-toggle/Dont.png)

</DoDont>

---

## Content guidelines
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,13 @@ Tertiary actions should:

#### Do

![Screenshot of modal with a plain button as a tertiary action](/images/components/internal-only/modal/[email protected])
![Screenshot of modal with a plain button as a tertiary action](/images/components/deprecated/modal/[email protected])

Use a plain button for a tertiary action if needed

#### Don’t

![Screenshot of modal with a destructive button as a tertiary action](/images/components/internal-only/modal/[email protected])
![Screenshot of modal with a destructive button as a tertiary action](/images/components/deprecated/modal/[email protected])

Use a tertiary action for a destructive action

Expand Down
File renamed without changes
File renamed without changes

0 comments on commit 5d4742a

Please sign in to comment.