forked from Shopify/polaris
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FooterHelp] Add align property (Shopify#11764)
### WHY are these changes introduced? This change will allow UX and devs the ability to chose an alignment for the FooterHelp component. Some footer layouts are being created with left-aligned text and they would like to see the footer help component utilize the same alignment. ### WHAT is this pull request doing? Adds an align property with the options `left | center | right` with the default continuing to be `center`. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
- Loading branch information
1 parent
5bb08c6
commit 67c1ded
Showing
7 changed files
with
84 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@shopify/polaris': minor | ||
--- | ||
|
||
Added align property for FooterHelp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import {BlockStack, FooterHelp, Link} from '@shopify/polaris'; | ||
import React from 'react'; | ||
import {withPolarisExample} from '../../src/components/PolarisExampleWrapper'; | ||
|
||
function FooterHelpAlignExample() { | ||
return ( | ||
<BlockStack gap="1600"> | ||
<FooterHelp align="start"> | ||
Start{' '} | ||
<Link url="https://help.shopify.com/manual/orders/fulfill-orders"> | ||
fulfilling orders | ||
</Link> | ||
</FooterHelp> | ||
<FooterHelp align="center"> | ||
Center{' '} | ||
<Link url="https://help.shopify.com/manual/orders/fulfill-orders"> | ||
fulfilling orders | ||
</Link> | ||
</FooterHelp> | ||
<FooterHelp align="end"> | ||
End{' '} | ||
<Link url="https://help.shopify.com/manual/orders/fulfill-orders"> | ||
fulfilling orders | ||
</Link> | ||
</FooterHelp> | ||
</BlockStack> | ||
); | ||
} | ||
|
||
export default withPolarisExample(FooterHelpAlignExample); |