Skip to content

Add more validations #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AntoineGagne wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add more validations #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/robots_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"# ---------------------------\n"
"# END YOAST BLOCK\n"
>>).
-define(A_STRAY_RULE, <<"Disallow: /path/">>).
-define(ANOTHER_VALID_CONTENT,
<<"User-Agent: ", ?USER_AGENT/binary, "\nAllow: ", ?A_RULE/binary, "\nDisallow: ",
?ANOTHER_RULE/binary>>
Expand Down Expand Up @@ -67,7 +68,8 @@ groups() ->
return_false_if_agent_is_disallowed,
return_true_if_no_matching_rules_can_be_found,
return_true_if_everything_is_allowed_for_the_corresponding_agent,
ignore_empty_rules
ignore_empty_rules,
ignore_stray_rules
]}
].

Expand Down Expand Up @@ -259,6 +261,13 @@ ignore_empty_rules(_Config) ->

?assert(robots:is_allowed(?USER_AGENT, ?AN_URL, RulesIndex)).

ignore_stray_rules() ->
[{doc, "Given a stray rule, when parsing, then ignores the stray rules."}].
ignore_stray_rules(_Config) ->
{ok, RulesIndex} = robots:parse(?A_STRAY_RULE, ?A_VALID_CODE),

?assertEqual(#{}, RulesIndex).

%%%===================================================================
%%% Internal functions
%%%===================================================================