Skip to content

Conversation

@AntonButov
Copy link
Owner

@AntonButov AntonButov commented Apr 2, 2025

PR Type

Enhancement


Description

  • Refactored createTestProject to use createTempDirectory.

  • Added import for kotlin.io.path.createTempDirectory.

  • Removed redundant createTestProject declaration.


Changes walkthrough 📝

Relevant files
Enhancement
TestProject.kt
Update test project creation using createTempDirectory     

integration-tests/src/test/kotlin/TestProject.kt

  • Added import for kotlin.io.path.createTempDirectory.
  • Updated createTestProject to use createTempDirectory and convert to
    file.
  • Removed alternative createTestProject declaration using createTempDir.
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    github-actions bot commented Apr 2, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    API Change

    Verify that the switch from createTempDir to createTempDirectory and the conversion using .toFile() preserves the intended behavior. It is important to confirm that the new approach provides the same reliability and cleanup as before.

    import kotlin.io.path.createTempDirectory
    
    fun createTestProject(name: String = "test-project"): TestProject = TestProject(createTempDirectory(prefix = name).toFile())

    @github-actions
    Copy link

    github-actions bot commented Apr 2, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants