TOU Handshake Rework #187
Open
TOU Handshake Rework #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to use knowledge from the TOR handshake to make a new handshake for TOU. but, in order to add another feature (auto updating the mod like TOR does), the handshake has to more closely resemble TORs one, so im disappointed to say i changed less than i wanted, but made a few improvements, and put a placeholder in for where this can link into the auto updating of the mod (if that will even work). Either way, this fixes the crash bug, and ive left in the lobby features that were in the TOR handshake, because why remove them? i have hardcoded some to just work properly so settings can be coded in for them at a later date, and for other things ive implemented them as is as the features are just helpful. Credit should go to TOR for the handshake template/design as well as the additional features, i have modified it a bit and thrown in a few extras/improvements, otherwiise it pretty much follows hows theirs works.
|
I should also mention this was built on 2.9.0 as requested :) going to work on the auto updating now, so if there is any changes requested here, or questions, let me know. |
noticed i left this in by mistake while testing something, oops
|
@Anusien - i have merged this with the up to date code base and it works after merging. test branch is here, i merged using the same code as in this PR. |
|
Tested on the code for 3.0.0 beta 8, this worked fine, no crashes, no issues. |
forgot to change this before, as even 2022.2.8 runs on "2021.12.15" this should be the recognised version.. i dont know how this would be automatically coded though as i dont know where to pull this from, but miniguikboot i beleive said that 2022.2.8 identifies as "2021.12.15" for impostor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Anusien - this works so if it passes your testing (ive used 2 clients for every scenario.. different versions newer/older and same versions with different fork name's) and it works as expected on both ends, the only thing i cant 100% confirm is if it fixes the crash, but as ive played TOU with the TOR handshake (https://github.com/VirusTLNR/Town-Of-Us/tree/HandshakeFixOn2.8.1) and there was no crash, and this is a minor change from that, this will also not crash.
I wanted to use knowledge from the TOR handshake to make a new handshake for TOU. but, in order to add another feature interlinking with the handshake in the future (auto updating the mod like TOR does but hopefully with more features), the handshake has to more closely resemble TORs one, so I am disappointed to say this is less brand new code than i wanted as i had to make use of the TOR template for a handshake, but made a few improvements, and put a placeholder in for where this can link into the auto updating of the mod (if that will even work as i havent tested it yet.).
Either way, this fixes the crash bug, and ive left in the lobby features that were in the TOR handshake, because why remove them? they are great features. i have hardcoded some to just work properly so settings can be coded in for them at a later date, and for other things ive implemented them as is as the features are just helpful (like the lobby timer)
Credit should go to TOR for the handshake template/design as well as the additional features, i have modified it a bit and thrown in a few extras/improvements, otherwiise it pretty much follows hows theirs works.