Reject silent math overflow inside compute result - #139
Open
AgilityB wants to merge 2 commits into
Open
Conversation
…ount errors Updated: apexchainx_calculator/src/fuzz_tests.rs: test_fuzz_compute_result_overflow_rejects_silently_clamping now allows the overflow path to return either SLAError::InvalidPenaltyAmount or SLAError::InvalidRewardAmount (overflow can be detected at different arithmetic sites). Verified with cargo test -p apexchainx_calculator resulting in 425 passed; 0 failed.
Contributor
|
Thanks for hardening compute_result — exactly the kind of pragmatic work we want! Currently the Checks tab shows no completed runs for the four CI jobs that gate contracts here: That almost always means the per-PR workflow has not fired yet. Pushing a rebase (or an empty commit) onto latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented fuzz test fix in apexchainx_calculator/src/fuzz_tests.rs and ensured the test suite passes.
Completed the fix and verified tests pass.
Updated:
Closes #68