Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 552 (Tobias) #555

Merged
merged 10 commits into from
Dec 9, 2019
Merged

Fix issue 552 (Tobias) #555

merged 10 commits into from
Dec 9, 2019

Conversation

tobiasjpark
Copy link
Contributor

Partially Fixes #552

DO NOT DELETE ISSUE #552 AFTER APPROVING THIS PULL REQUEST, THIS ONLY SOLVES ONE ASPECT OF ISSUE #552

Proposed Changes

  • DashboardCalendarSelectModal now uses a Tab system. There is an Assignments tab (which displays assignments that users can schedule), a General Work Blocks tab (for scheduling general work blocks not associated with a particular assignment), and a To-Dos tab (for scheduling To-Dos). As of right now, only the Assignments tab works, as the backend code for General Work Blocks and To-Dos has not yet been implemented (I guess we shouldn't approve this pull request til after that's done?). However, I believe all of the frontend code is complete within this pull request.

Copy link
Owner

@Apexal Apexal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome start. Thanks!

@tobiasjpark tobiasjpark merged commit 6c7e7be into dev Dec 9, 2019
@tobiasjpark tobiasjpark deleted the fix-issue-552-tobias branch December 9, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamping the DashboardCalendarSelectModal
2 participants