[pull] v2 from parcel-bundler:v2 #318
Open
+118,987
−39,231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Fix types for typescript + feature flags * Add typescript checks to pull request build
* Implement a simple feature-flag client to avoid option drilling * Ensure feature flag client is initialised in workers * Rename featureFlags -> featureFlagValues * Avoid depending on ephemeral flag in test
* Fix gulp clean action * Revert unwanted change --------- Co-authored-by: Pedro Yamada <[email protected]>
* Fix all circular dependencies * Fix circular dependencies between packages and `@parcel/types` * Use generic WorkerFarm type parameter to avoid having to move/duplicate the class * Don't do deep imports to types * Fix accidental changes to package.json * Revert turbo related changes to package.json * Fix typescript errors * Fix more typescript errors * Move packages into a types-internal pkg This allows for there to be no API changes from the circular dependencies fix. There is now a `@parcel/types` package with the same API as before and a new `@parcel/types-internal` package, which is consumed by `@parcel/workers` while avoiding it. * Fix typescript issues * Fix eslint errors * Fix typescript errors * Add back fs dependency on parcel/types * Add missing exports * Fix dependency cycle * Fix package-manager breaking changes * Fix import duplication in ts declaration file --------- Co-authored-by: Pedro Yamada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )