Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unsupported features docs #192

Merged
merged 8 commits into from
Jun 30, 2023

Conversation

jakubsob
Copy link
Contributor

@jakubsob jakubsob commented Jun 1, 2023

Changes

Closes #188

@jakubsob jakubsob requested a review from kamilzyla June 1, 2023 10:16
Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 💯 The Button3.R example could use a small tweak (see my comment), but I'm fine merging it as is too.

inst/examples/Button3.R Outdated Show resolved Hide resolved
@jakubsob jakubsob force-pushed the docs/188-improve-unsupported-features-docs branch from 4445276 to e402e87 Compare June 29, 2023 11:54
@jakubsob jakubsob force-pushed the docs/188-improve-unsupported-features-docs branch from e402e87 to 398f9e5 Compare June 30, 2023 11:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #192 (ba174e1) into main (d3e3bb9) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   12.72%   12.72%           
=======================================
  Files           5        5           
  Lines          55       55           
=======================================
  Hits            7        7           
  Misses         48       48           

@jakubsob jakubsob merged commit 98c27cb into main Jun 30, 2023
1 check passed
@jakubsob jakubsob deleted the docs/188-improve-unsupported-features-docs branch June 30, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for unsupported features with workarounds
3 participants