Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dataset calls in vignettes with box imports #200

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

PawanRamaMali
Copy link
Contributor

In vignettes, dataset calls follow the :: pattern due to a bug in the box package. Since the bug has been fixed and the new version of box is available on CRAN, all :: calls should be replaced with the proper box import.

Changes

  • replaced dataset calls in rhino tutorials with box imports

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #200 (6a64b8d) into main (96d2e9f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   12.72%   12.72%           
=======================================
  Files           5        5           
  Lines          55       55           
=======================================
  Hits            7        7           
  Misses         48       48           

Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks @PawanRamaMali! 😊

Here I'd suggest:

  1. Say that Rhino v1.4.0 or later is required at the beginning of the tutorial.
  2. Adjust the tutorial - just assume the box issues are now fixed.

Of course we'll need to wait with this PR until Rhino 1.4.0 is released.

This way we are encouraging people to use the latest version of Rhino and making the tutorial easier to understand.

Copy link
Contributor

@jakubsob jakubsob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all criteria are met, Rhino 1.4.0 was released and tutorial has been adjusted. Approved ✅

@magdakunat magdakunat merged commit f2f19e1 into main Aug 11, 2023
1 check passed
@magdakunat magdakunat deleted the docs-update-dataset-calls-in-vignettes branch August 11, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants