Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix demo app and update package dependencies #202

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix demo app and update package dependencies #202

merged 2 commits into from
Aug 31, 2023

Conversation

jakubsob
Copy link
Contributor

Changes

Closes #195

How to test

Install the package:

remotes::install_github("Appsilon/shiny.fluent@feat/195-fix-demo-app", dependencies = "Suggests")

check that demo app is working:

shiny.fluent::runExample("demo")

@averissimo averissimo self-assigned this Aug 29, 2023
averissimo
averissimo approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great that you updated to the new shiny.router API 👍

@jakubsob jakubsob merged commit ed1c67e into main Aug 31, 2023
1 check passed
@jakubsob jakubsob deleted the feat/195-fix-demo-app branch August 31, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averissimo averissimo averissimo approved these changes

Assignees

@averissimo averissimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shiny.fluent::runExample("demo") returns Error in $: $ operator is invalid for atomic vectors
2 participants
@jakubsob @averissimo