Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved linux and windows build scripts, updated readme #348

Merged
merged 13 commits into from
Jul 24, 2024
Merged

improved linux and windows build scripts, updated readme #348

merged 13 commits into from
Jul 24, 2024

Conversation

kushaljain-apra
Copy link
Collaborator

@kushaljain-apra kushaljain-apra commented Apr 24, 2024 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[341]

Description

Improved linux build scripts -

  • to be build without any root permissions
  • to check for copying path to .bashrc to avoid duplicate entries
  • added checker to avoid cudnn file extraction when extracted folder is already available
  • added a flag which can be passed with the build script to build documentation

Improved windows build scripts -

  • added checker to avoid cudnn file extraction when extracted folder is already available
  • added a flag which can be passed with the build script to build documentation
  • add --config during building because CMAKE_BUILD_TYPE flag does not work for windows, which will now build the correct build type

Updated Readme -

  • updated readme with documentation and build command changes

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@kushaljain-apra kushaljain-apra linked an issue Apr 24, 2024 that may be closed by this pull request
Root Permission for building ApraPIpes #341
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 13s ⏱️ ±0s
308 tests ±0  227 ✅ ±0  81 💤 ±0  0 ❌ ±0 
227 runs  ±0  146 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit 93ec72a. ± Comparison against base commit 401b9eb.

♻️ This comment has been updated with latest results.

@joiskash joiskash changed the base branch from main to kj/ApraNVR_CommonBuild_vcpkg April 25, 2024 09:11
@yashrajsapra yashrajsapra changed the base branch from kj/ApraNVR_CommonBuild_vcpkg to main April 25, 2024 11:42
@kushaljain-apra kushaljain-apra changed the title improved linux build scripts improved linux and windows build scripts, updated readme May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Test Results Linux-CudaT

  1 files    1 suites   11m 57s ⏱️
409 tests 249 ✅ 160 💤 0 ❌
249 runs   89 ✅ 160 💤 0 ❌

Results for commit 93ec72a.

♻️ This comment has been updated with latest results.

yashrajsapra
yashrajsapra previously approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@yashrajsapra yashrajsapra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Script look's good, It has fixed all the issues that we faced before

@venkat0907 venkat0907 self-requested a review May 31, 2024 10:54
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Test Results Windows-cuda

  1 files  ±0    1 suites  ±0   12m 6s ⏱️ ±0s
404 tests ±0  288 ✅ ±0  116 💤 ±0  0 ❌ ±0 
288 runs  ±0  172 ✅ ±0  116 💤 ±0  0 ❌ ±0 

Results for commit 93ec72a. ± Comparison against base commit 401b9eb.

♻️ This comment has been updated with latest results.

venkat0907
venkat0907 previously approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@venkat0907 venkat0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check linux build once

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Test Results Linux_ARM64

  1 files  ±0    1 suites  ±0   11m 6s ⏱️ +10s
431 tests ±0  259 ✅ ±0  172 💤 ±0  0 ❌ ±0 
259 runs  ±0   87 ✅ ±0  172 💤 ±0  0 ❌ ±0 

Results for commit 93ec72a. ± Comparison against base commit 401b9eb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Test Results Win-nocuda

  1 files  ±0    1 suites  ±0   10m 29s ⏱️ -1s
303 tests ±0  227 ✅ ±0  76 💤 ±0  0 ❌ ±0 
227 runs  ±0  151 ✅ ±0  76 💤 ±0  0 ❌ ±0 

Results for commit 93ec72a. ± Comparison against base commit 401b9eb.

♻️ This comment has been updated with latest results.

@mraduldubey mraduldubey merged commit 62d7a07 into main Jul 24, 2024
18 of 21 checks passed
@mraduldubey mraduldubey deleted the build_scripts-update branch July 24, 2024 13:37
Vinayak-YB pushed a commit that referenced this pull request Aug 7, 2024
@kushaljain-apra @Vinayak-YB
improved linux and windows build scripts, updated readme (#348)
7286500 
* improve linux build scripts

* update jeston build script

* update build scripts to run .bashrc from home

* added --build-doc flag in linux scripts

* update windows build scripts

* remove sudo from cloud build scripts

* update readme with build commands and documentation generation commands

* Update build_dependencies_linux_cuda.sh

* Update README.md

* update windows build scripts to build with correct build type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraduldubey mraduldubey mraduldubey approved these changes

@yashrajsapra yashrajsapra yashrajsapra left review comments

@venkat0907 venkat0907 venkat0907 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Root Permission for building ApraPIpes
4 participants
@kushaljain-apra @mraduldubey @yashrajsapra @venkat0907