Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added redis with event source module #76

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AkshayPS12
Copy link
Contributor

@AkshayPS12 AkshayPS12 commented Feb 9, 2022

For creating listening to events and using setProps to change props of running modules. In this case events are generated by redis keyspace notifications.

Checklist

  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@AkshayPS12 AkshayPS12 added enhancement New feature or request Feature labels Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unit Test Results

0 files   -     2  0 suites   - 2   0s ⏱️ -46s
0 tests  - 181  0 ✔️  - 110  0 💤  -   71  0 ±0 
0 runs   - 176  0 ✔️  -   61  0 💤  - 115  0 ±0 

Results for commit 2fb2aef. ± Comparison against base commit 099c293.

This pull request removes 181 tests.
ImageEncodeCV_tests ‑ MONO_profile
ImageEncodeCV_tests ‑ RGB_profile
ImageEncodeCV_tests ‑ bgra_profile
ImageEncodeCV_tests ‑ color_bgra_1920x960
ImageEncodeCV_tests ‑ color_rgb_1280x720
ImageEncodeCV_tests ‑ mono1_1920x960
Imageresizecv_tests ‑ MONO_profile
Imageresizecv_tests ‑ RGB_profile
Imageresizecv_tests ‑ bgra_profile
Imageresizecv_tests ‑ color_rgb_1280x720
…

♻️ This comment has been updated with latest results.

@AkshayPS12
Copy link
Contributor Author

looks like it is not compatible with 1.3.1 redis++ port on vcpkg. The version I had built from source was 1.3.2 , hence the port must be added or it should be built from source.

@AkshayPS12
Copy link
Contributor Author

I made a PR for updating redis++ version to 1.3.2 on vcpkg which got approved here. Please pull it from upstream to apralabs/vcpkg submodule. This should fix the issue.

@AkshayPS12
Copy link
Contributor Author

@kumaakh @joiskash

@joiskash
Copy link
Collaborator

@AkshayPS12 awesome! sorry for the late response. I will look into this! Thanks!

@joiskash joiskash self-assigned this Apr 21, 2022
@joiskash
Copy link
Collaborator

joiskash commented May 3, 2022

I have updated the vcpkg submodule @AkshayPS12 can you just check if it works

@AkshayPS12
Copy link
Contributor Author

vcpkg old cache persisting , checksums for cache rebuild should have more context/logic

@AkshayPS12
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants