Add names to tag detections#150
Open
jack-slip wants to merge 2 commits intoAprilRobotics:masterfrom
Open
Conversation
…undles by consumers of tag detections
wxmerkt
reviewed
Apr 24, 2023
Collaborator
wxmerkt
left a comment
wxmerkt
left a comment
There was a problem hiding this comment.
Thank you for the PR. While I agree with the usefulness of having the names, we don't want to change messages of released packages (it would make rosbags etc. incompatible) - sorry
Contributor
Author
Understood. Would you be in favor of the default behavior being the current message structure for backwards compatibility, but have an optional param that can enable publishing of a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be useful for hashing tag bundles for consumers of a /tag_detection stream