Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Unified exhaustive data-timeline-id parsing #1485

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jun 5, 2024

Description

This is the most horrifying thing I have ever created using javascript. I wanted to give it a try, though, as I figured I could cherry-pick snippets/solutions/concepts from it for whatever we actually wind up implementing.

I did wind up kind of liking passing a filter function directly into filterPostElements. Pretty much all of the "generate multiple outputs from one set of source data that describes the timeline ids" code isn't worthwhile, though, or at least I couldn't figure out a form for it that's any good.

Testing steps

@marcustyphoon marcustyphoon changed the title Experiment: Unified exhaustive data-timeline-id parsing Experiment: Unified exhaustive data-timeline-id parsing Jun 5, 2024
@marcustyphoon
Copy link
Collaborator Author

@marcustyphoon
Copy link
Collaborator Author

Aw, man. Tagged pages break this paradigm, as you have to be able to treat data-timeline-id="hubsTimeline-some tag-recent-search_box_suggestion_followed_tag" and data-timeline-id="hubsTimeline-some tag-recent-undefined" the same way, which would have to become a [data-timeline-id^="etc"] CSS selector only in that specific case, which is hard to automate.

I mean, maybe you could ^= all of them, particularly with the fixes to patio timeline ids I'm waiting on? That would probably break in certain scenarios in the engineered cases like "my blog name is undefined-undefined" unless ids are tweaked further, but I mean, who really cares.

@marcustyphoon
Copy link
Collaborator Author

collection:

regular, v1; patio, v1: data-timeline="/v2/timeline" data-which="pack"
patio, v2: data-timeline-id=collection-[columnid]-collectionid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant