Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Scroll to Bottom on Timeline V2 (modal branch) #1492

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jun 11, 2024

likely to be rebased.

also I can't PR a branch against an external PR branch; that's sad

Description

This implements Scroll to Bottom on V2 timelines.

As noted in the linked issue, on V2 timelines, the loader element we need to detect so that we keep scrolling conditionally:

  • Isn't the last child of its parent anymore (and doesn't have a classname iirc?)
  • Doesn't exist unless the timeline is actively loading content

Thus, this:

  • Fixes the selector
  • Implements new logic: scrolling will stop after a short delay unless a loader is added during the delay window. (This is basically equivalent to "debounce the stopscrolling function" in some meaningful sense, though I believe literally doing that has some bad edge cases. Didn't think this through much; if that works we should do it so the code is easier to understand.)

Resolves #1491

Testing steps

marcustyphoon and others added 29 commits February 15, 2023 15:56
There must be a better way to do this.
still trying to find a better method for this
@marcustyphoon marcustyphoon changed the title Implement Scroll to Bottom on Timeline V2 Implement Scroll to Bottom on Timeline V2 (modal branch) Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll to Bottom breaks on some timelines; blog lists; activity
2 participants